Update TrackReco HitPattern in light of GEM now including GE0 #35205

watson-ij · 2021-09-09T05:52:33Z

PR description:

Updates TrackReco HitPattern to include GE0 in GEM, while keeping it backward compatible for GE1/1 and GE2/1 (i.e. those stations should have same bit pattern as before). Fixes a bug in the decoder which was previously reading the GEM station incorrectly. The HitPattern for GEM is not used so far, so no changes in the output is expected. Requested here: #35033 (comment)

@jshlee @slava77

PR validation:

Ran a ten mu 2026 workflow and checked it ran to completion. Checked the output of printHitPattern after adding in a GEM hit, reads out correctly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

…g backward compatible

cmsbuild · 2021-09-09T05:58:21Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35205/25149

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35205/25149/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35205/25149/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-09-09T06:08:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35205/25151

This PR adds an extra 32KB to repository

cmsbuild · 2021-09-09T06:08:36Z

A new Pull Request was created by @watson-ij (Ian J. Watson) for master.

It involves the following packages:

DataFormats/TrackReco (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@JanFSchulte, @rovere, @VinInn, @gpetruc, @mmusich, @mtosi this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2021-09-09T12:10:59Z

@cmsbuild please test

cmsbuild · 2021-09-09T16:44:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f24d83/18445/summary.html
COMMIT: 3a20969
CMSSW: CMSSW_12_1_X_2021-09-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35205/18445/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3001001
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000979
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

slava77

please also check that HitPattern::printHitPattern is correct for GEM after this update.

slava77

it looks like neither getGEMStation nor getGEMLayer are used in computing anything in cmssw, except for some test printouts via HitPattern::printHitPattern. So, the validation plots are not expected to change.

please also check that HitPattern::printHitPattern is correct for GEM after this update.

DataFormats/TrackReco/interface/HitPattern.h

slava77 · 2021-09-10T02:59:39Z

DataFormats/TrackReco/interface/HitPattern.h

+    uint16_t sss = getSubSubStructure(pattern);
+    if (sss & 0b1000)
+      return 0;
+    return (sss >> 2) + 1;


this looks like a bugfix (a shift by 2 instead of 1 in view of what was encoded as (gemid.station() - 1) << 2.
Please add a more explicit note about this in the PR description.

Updated the PR

watson-ij · 2021-09-10T03:15:39Z

@slava77 Ok thanks. I'll check the print function first, then update the code and PR description

Co-authored-by: Slava Krutelyov <[email protected]>

cmsbuild · 2021-09-10T08:20:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35205/25182

This PR adds an extra 32KB to repository

cmsbuild · 2021-09-10T08:20:33Z

Pull request #35205 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2021-09-10T12:48:45Z

@cmsbuild please test

cmsbuild · 2021-09-10T17:04:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f24d83/18489/summary.html
COMMIT: 42d511b
CMSSW: CMSSW_12_1_X_2021-09-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35205/18489/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3001001
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000973
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

slava77 · 2021-09-10T22:47:30Z

+reconstruction

for #35205 42d511b

code changes are in line with the PR description and the follow up review (this includes both the update to support the combined handling of ME0 as GEM station 0 as well as some originally present bugs in getGEMStation and printHitPattern implementations)
jenkins tests pass and comparisons with the baseline show no differences (the modified / updated variables are not monitored directly)

cmsbuild · 2021-09-10T22:48:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-09-11T00:59:31Z

+1

makortel · 2021-09-15T12:56:30Z

ASAN reports an issue possibly caused by this PR, please see #35283

Update TrackReco HitPattern in light of GEM now including GE0, keepin…

990feb5

…g backward compatible

cmsbuild added this to the CMSSW_12_1_X milestone Sep 9, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 9, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 9, 2021

Code format

3a20969

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 9, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 9, 2021

slava77 mentioned this pull request Sep 9, 2021

[UBSAN] Undefined behavior in DataFormats/* reco packages #35033

Closed

cmsbuild added tests-approved and removed tests-started labels Sep 9, 2021

slava77 reviewed Sep 10, 2021

View reviewed changes

Fix layer

01c1b2c

Co-authored-by: Slava Krutelyov <[email protected]>

cmsbuild removed tests-approved code-checks-approved labels Sep 10, 2021

cmsbuild added the code-checks-rejected label Sep 10, 2021

Code format

42d511b

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 10, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 10, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 10, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 10, 2021

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Sep 10, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 11, 2021

cmsbuild merged commit e95de19 into cms-sw:master Sep 11, 2021

This was referenced Sep 11, 2021

add 11634.7 wf for 2021 ttbar mkFit to the short matrix #35235

Merged

Updated root to tip of branch master cms-sw/cmsdist#7299

Merged

fix undefined behavior in MultiTrackValidator #35086

Merged

dan131riley mentioned this pull request Sep 15, 2021

AddressSanitizer: stack-buffer-underflow reco::HitPattern::muonStations #35283

Closed

slava77 mentioned this pull request Oct 26, 2021

Using new Run3ScoutingHitPattern class for hitPattern in Run-3 scouting #35685

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update TrackReco HitPattern in light of GEM now including GE0 #35205

Update TrackReco HitPattern in light of GEM now including GE0 #35205

watson-ij commented Sep 9, 2021 •

edited

Loading

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

slava77 commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

slava77 left a comment

slava77 left a comment

slava77 Sep 10, 2021

watson-ij Sep 10, 2021

watson-ij commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

slava77 commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

slava77 commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

qliphy commented Sep 11, 2021

makortel commented Sep 15, 2021

Update TrackReco HitPattern in light of GEM now including GE0 #35205

Update TrackReco HitPattern in light of GEM now including GE0 #35205

Conversation

watson-ij commented Sep 9, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

slava77 commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

Comparison Summary

slava77 left a comment

Choose a reason for hiding this comment

slava77 left a comment

Choose a reason for hiding this comment

slava77 Sep 10, 2021

Choose a reason for hiding this comment

watson-ij Sep 10, 2021

Choose a reason for hiding this comment

watson-ij commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

slava77 commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

Comparison Summary

slava77 commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

qliphy commented Sep 11, 2021

makortel commented Sep 15, 2021

watson-ij commented Sep 9, 2021 •

edited

Loading